Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Nepali (ne) language #2132

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Add support to Nepali (ne) language #2132

merged 1 commit into from
Jun 9, 2021

Conversation

MuriloDalRi
Copy link
Contributor

https://trello.com/c/cSuhVSSq/2550-add-nepalese-translation-option-to-whitehall

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@bevanloon bevanloon temporarily deployed to government-f-add-nepali-m2lsb6 June 7, 2021 14:46 Inactive
Copy link
Member

@brucebolt brucebolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but as with the Whitehall PR I don't think we need all the plural forms.

@bevanloon bevanloon temporarily deployed to government-f-add-nepali-m2lsb6 June 8, 2021 09:45 Inactive
@MuriloDalRi MuriloDalRi requested a review from brucebolt June 9, 2021 08:44
@MuriloDalRi
Copy link
Contributor Author

Looks good to me, but as with the Whitehall PR I don't think we need all the plural forms.

Fixed.

Copy link
Member

@brucebolt brucebolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@MuriloDalRi MuriloDalRi merged commit bff5929 into main Jun 9, 2021
@MuriloDalRi MuriloDalRi deleted the add-nepali branch June 9, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants