-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Save page box #2121
Merged
Merged
Add new Save page box #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
save_page_box
branch
from
May 27, 2021 13:44
8c4f8fb
to
541e87e
Compare
barrucadu
reviewed
May 27, 2021
danacotoran
force-pushed
the
save_page_box
branch
from
May 27, 2021 14:05
541e87e
to
b77b0fc
Compare
huwd
reviewed
May 28, 2021
huwd
reviewed
May 28, 2021
huwd
reviewed
May 28, 2021
huwd
reviewed
May 28, 2021
huwd
reviewed
May 28, 2021
huwd
reviewed
May 28, 2021
huwd
reviewed
May 28, 2021
huwd
reviewed
May 28, 2021
huwd
reviewed
May 28, 2021
danacotoran
force-pushed
the
save_page_box
branch
from
June 1, 2021 10:55
f43f9dd
to
73d2591
Compare
danacotoran
force-pushed
the
save_page_box
branch
from
June 1, 2021 11:06
73d2591
to
d5e7959
Compare
huwd
approved these changes
Jun 1, 2021
owenatgov
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this a quick frontend sweep and left some non-blocking comments. Great work 👍
danacotoran
force-pushed
the
save_page_box
branch
from
June 1, 2021 13:49
d5e7959
to
8e4a197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
save-this-page
component togovernment-frontend
.The work for this was originally done on the components gem.
However, in the meanwhile it was decided that in the early stages of our experiment, we would only be trialling the component on select pages on the
government-frontend
app. Adding this as an app-level component at first will ensure that we can iterate on it rapidly in the initial stages (if needed). This code is mostly copied over from the original PR with some fairly significant differences in the tests, as a result of the testing libraries being different.Nothing renders without a
page_path
parameter. The component also takes two other optional arguments:page_is_saved
andsigned_in
.Default (or when the user is signed out)
User is signed in and has not saved this page
User is signed in and has already saved this page
https://trello.com/c/ZTr0V9gB/770-implement-a-re-usable-save-unsave-component-corresponding-backend-code-in-government-frontend