Replace context link with breadcrumb #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-gds
approved these changes
Jul 9, 2021
|
All looks good to me |
chris-gds
reviewed
Jul 9, 2021
| }, | ||
| { | ||
| title: "History of the UK Government", | ||
| url: "/government/history", |
There was a problem hiding this comment.
I do wonder if there's a way to automate these for breadcrumbs so no matter where it appears on the site - via the gem - it's pre-populated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://trello.com/c/3ENWcE93/729-confusing-contextual-link-on-some-pages
Remove the link from the context text on the main heading, add breadcrumb to replace it.
Why
The styling of the contextual text in the component doesn't indicate in any way that it is a link without user interaction. We plan to remove the ability to add links from the components gem. We decided to preserve the linking back to the History page by adding a breadcrumb. The wording there more explicitly describes where the link goes.
Screenshots
Before
After