Remove unused i18n keys #2086
Remove unused i18n keys #2086
Conversation
This is the gem used by Content Publisher to track which i18n keys are untested (and therefore possibly unused). The coverage report is generated in `coverage/i18n`, which is git-ignored.
Removes unused `common.last_updated` field. I did consider using this in published-dates.html.erb, but the string prefix with the date varies from language to language, so this is better handled in the (previously unused) `components.published_dates`' `last_updated` and `published` fields. At time of writing, these fields don't exist outside of en.yml, which may be the reason behind the mixture of unused fields and hardcoded text. We will standardise these keys later.
These keys, identified by the "i18n-coverage" gem, don't appear to be used anywhere. There are a number of other keys which the gem complains about, but these are dynamically referenced so are difficult to statically analyse. My assumption is that they are used.
See 5e768df for commit which removed these keys from the English locale. This commit removes the same keys from all other locale files.
|
Do we know if there's any risk or problems with lines like causing us to think a translation isn't used when actually it is? |
Yes, that is a risk. I manually searched for portions of the key, rather than the entire key, so that I could spot programmatic occurrences like this, in which case I've kept the keys rather than removed them. I think the bigger risk is that there are some schema names in the i18n which aren't ever called upon programmatically. If, for example, there is no |
|
I spotted a slight issue with the config here while testing: #2112 |
This PR adds the i18n-coverage gem to monitor untested i18n keys. I've then removed used the coverage reports to identify and remove unused keys. See commits for details.
Trello: https://trello.com/c/Z3Pitrfg/2454-identify-and-remove-unused-keys-in-locale-files-5