Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translation keys that do not exist in the English version #2059

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

benjamineskola
Copy link
Contributor

@benjamineskola benjamineskola commented Mar 24, 2021

Most of these are blank keys anyway. The exception is the taxonomy_navigation key which only exists in Arabic and Russian.

https://trello.com/c/qlDQFq2I/2428-3-remove-locale-keys-with-no-english-translation

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Most of these are blank keys anyway. The exception is the `taxonomy_navigation` key which only exists in Arabic and Russian.
@bevanloon bevanloon temporarily deployed to government-f-remove-unu-dryoxq March 24, 2021 15:44 Inactive
@benjamineskola benjamineskola force-pushed the remove-unused-locale-keys branch from 7edd05b to 8580e5c Compare March 24, 2021 15:44
@bevanloon bevanloon temporarily deployed to government-f-remove-unu-3sxbm9 March 24, 2021 15:45 Inactive
@MuriloDalRi
Copy link
Contributor

Is there any reason why those translations only exist in Arabic and Russian?

@benjamineskola
Copy link
Contributor Author

Is there any reason why those translations only exist in Arabic and Russian?

I'm not really sure. It does make me a little suspicious — but I also can't find anywhere where they would be used from, either. (And after all if they were used then we would notice odd behaviour on the English version of the pages.)

@benjamineskola benjamineskola merged commit 44b8424 into master Mar 25, 2021
@benjamineskola benjamineskola deleted the remove-unused-locale-keys branch March 25, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants