Update back-to-top SVG arrow attributes #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was recommended on GOVUK Accounts team's DAC report that focusable="false" and aria-hidden="true" are added to the "up arrow" SVG on our Privacy notice and Accessibility statement page. This is because SVGs are in tab sequence in IE, which means that focus disappears as it sequences over them. Adding focusable="false" ensures the SVG is not in tab sequence, while aria-hidden="true" ensures that it is hidden from screen readers.
andysellick
approved these changes
Mar 16, 2021
AlanGabbianelli
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recommended on GOVUK Accounts team's DAC report that
focusable="false"andaria-hidden="true"are added to the "up arrow" SVG on our Privacy notice and Accessibility statement page:SVGs are in tab sequence in IE, which means that focus disappears as it sequences over them. Adding
focusable="false"ensures the SVG is not in tab sequence, whilearia-hidden="true"ensures that it is hidden from screen readers.https://trello.com/c/lNkwruEi/647-fix-accessibility-issues-raised-by-dac