Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #2044

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Remove unused code #2044

merged 1 commit into from
Mar 11, 2021

Conversation

chao-xian
Copy link
Contributor

These private methods aren't used anywhere.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

These private methods aren't used anywhere.
@bevanloon bevanloon temporarily deployed to government-f-remove-red-3hwsju March 11, 2021 10:06 Inactive
@chao-xian
Copy link
Contributor Author

Hmm the Heroku preview isn't rendering the related links for this page https://government-f-remove-red-3hwsju.herokuapp.com/guidance/national-lockdown-stay-at-home but it should https://www.gov.uk/guidance/national-lockdown-stay-at-home

@chao-xian chao-xian changed the title Remove unused code [DO NOT MERGE] Remove unused code Mar 11, 2021
@chao-xian
Copy link
Contributor Author

Added a DO NOT MERGE while I check this...

@chao-xian
Copy link
Contributor Author

OK it's because only specific environments have a header to toggle the functionality alphagov/govuk-cdn-config@a00977e so this works fine as I deployed the branch to integration and it still works.

Screenshot 2021-03-11 at 11 47 58

@chao-xian chao-xian changed the title [DO NOT MERGE] Remove unused code Remove unused code Mar 11, 2021
@chao-xian chao-xian merged commit 3ee554e into master Mar 11, 2021
@chao-xian chao-xian deleted the remove-redundant-method branch March 11, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants