Fix flaky random publication tests #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By running `merge` rather than `merge!` this wasn't actually mutating
the underlying hash and thus not having an effect.
This helps to resolve a problem where a new publication document type
has been added and causes some tests to fail. For example:
```
test_random_but_valid_items_do_not_error ERROR (0.39s)
Minitest::UnexpectedError: ActionView::Template::Error: translation missing: zh.content_item.schema_name.standard
app/views/content_items/publication.html.erb:10
app/controllers/content_items_controller.rb:149:in `block in render_template'
app/controllers/content_items_controller.rb:183:in `block in with_locale'
app/controllers/content_items_controller.rb:183:in `with_locale'
app/controllers/content_items_controller.rb:148:in `render_template'
app/controllers/content_items_controller.rb:25:in `show'
```
This resolves a couple of scenarios where assumptions are made that documents will have attachments and attachments with particular ids exist. This is data that developers assume is the case (and most likely is) but is beyond the guarantees that schemas make. This mismatch can cause tests to fail when valid schemas are generated which cannot be rendered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to find three causes to a problem where unique schemas weren't being generated for the random publication test.
More info in the commits.