Updates for How To Vote guide #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihugh
force-pushed
the
voting-intent-schema
branch
from
29d27ae to
fc8bce7
Compare
alex-ju
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Looks good overall. Only one content-related comment to be checked. I don't mind longer pages as long as users can navigate to them using the contents list and share direct links to those sections. I get that this is a trial and we can make the 'bespoke' code more generic if we decide to move more guides to this model.
This has been updated to include the highlighted text from [the content document](https://docs.google.com/document/d/17i_0rH67XgBn2dy0DIQbCC0PLxiZofTkohbw042qtV0/edit?ts=603e18cb#)
This code was recently resurrected, and it refers to the old way of stubbing using the gds-api-adapters test helpers. Fixed!
This indicates what we think the most common related services are.
sihugh
force-pushed
the
voting-intent-schema
branch
from
fc8bce7 to
b7758aa
Compare
Totally agree 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to run https://www.gov.uk/how-to-vote as a single page guide up to the local elections. This allows us to use the FAQPage schema to extend the reach of the content of this page to other platforms.
We wrote about doing this for the general election.
This PR resurrects the old way of doing this, by:
Note, we may want to review the single page guide template, as some elements of GOV.UK frontend have moved on.
https://government-f-voting-int-jrhxkr.herokuapp.com/how-to-vote