Replace sanitize with raw for legacy document list #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sanitize` was stripping out the `tabindex` attribute from the legacy document list markup provided by Whitehall. `sanitize` requires an allowlist of attributes, but a more future-proof option is to use `raw` since this is markup from a trusted source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace
sanitizewithrawfor the legacy pre-rendered documents list.Why
sanitizewas stripping out thetabindexattribute from the legacy document list markup provided by Whitehall.sanitizerequires an allowlist of attributes, but a more future-proof option is to userawsince this is markup from a trusted source.Visual differences
The document icon was focusable with an invisible focus state - so a user could tab there but there was no visual indication that the document icon was focused. This removes that link from the tab index, so it's no longer reachable by tabbing through the page. This means that the tab focus jumps from the document title to the next document title without detouring.