Switch from static to govuk_publishing_components scripts #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script (and associated styles) is only being used in government frontend, hence no reason to serve it in all applications.
We only use this prefix for styles coming from `govuk-frontend`
8 tasks
alex-ju
changed the title
alex-ju
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
trackClickscript togemTrackClickscript. They are virtually the same, the latter being copied over fromstatictogovuk_publishing_componentstogglescript togemTogglescriptsticky-element-containerfromstaticas this app is the only one using it (PR prepared to remove it fromstaticafter this gets merged)Why
Part of a bigger piece of work to reduce the size of assets served to users and keep our codebase to a minimum.