-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 'standard' publication types to be rendered #2003
Conversation
923dd45
to
211041d
Compare
I've pushed some commits since reviewing
211041d
to
0f3e576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I've been a little out of the loop on the i18n standardisation stuff. Is there a reason why the English version only has one
and other
defined, and all the translations have other (empty) counts which will likely never have values?
one: Safon | ||
two: | ||
few: | ||
many: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the empty zero
/two
/few
/many
properties, like in the English version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pluralisation rules for Welsh require us to have a zero
, two
, few
and many
value. We weren't provided with translations for these, so the empty values should help us identify outstanding translations when we do this piece of work. I've also done the same for other languages that don't have a one-other
pluralisation rule (e.g. Croatian).
Adds locales needed to render the new 'standard' document type.
I've added the foreign translation placeholders as they are used unlike the the ones located in Whitehall. We'll need to decide if we want a translation for all locales, some or just for English.
Dependent on:
Trello:
https://trello.com/c/ugeapNY0/2318-5-create-new-standard-document-sub-type-in-whitehall