Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'standard' publication types to be rendered #2003

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

1pretz1
Copy link
Contributor

@1pretz1 1pretz1 commented Feb 1, 2021

Adds locales needed to render the new 'standard' document type.

I've added the foreign translation placeholders as they are used unlike the the ones located in Whitehall. We'll need to decide if we want a translation for all locales, some or just for English.

Dependent on:

  • Foreign locale translations being agreed upon and implemented (decision is for no translations to be created initially)

Trello:
https://trello.com/c/ugeapNY0/2318-5-create-new-standard-document-sub-type-in-whitehall

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@bevanloon bevanloon temporarily deployed to government-f-add-standa-zygp42 February 1, 2021 17:05 Inactive
brucebolt
brucebolt previously approved these changes Feb 2, 2021
@brucebolt brucebolt force-pushed the add-standard-translations branch from 923dd45 to 211041d Compare March 23, 2021 13:58
@brucebolt brucebolt dismissed their stale review March 23, 2021 14:10

I've pushed some commits since reviewing

@brucebolt brucebolt force-pushed the add-standard-translations branch from 211041d to 0f3e576 Compare March 23, 2021 14:12
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I've been a little out of the loop on the i18n standardisation stuff. Is there a reason why the English version only has one and other defined, and all the translations have other (empty) counts which will likely never have values?

one: Safon
two:
few:
many:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the empty zero/two/few/many properties, like in the English version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pluralisation rules for Welsh require us to have a zero, two, few and many value. We weren't provided with translations for these, so the empty values should help us identify outstanding translations when we do this piece of work. I've also done the same for other languages that don't have a one-other pluralisation rule (e.g. Croatian).

@brucebolt brucebolt merged commit 8a0969c into master Mar 24, 2021
@brucebolt brucebolt deleted the add-standard-translations branch March 24, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants