Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component references #1982

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Fix component references #1982

merged 2 commits into from
Jan 18, 2021

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Jan 14, 2021 •
edited
Loading

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Update component references following this change to correct component file names: alphagov/govuk_publishing_components#1848

Also taking the opportunity to add missing print styles for the skip link component.

@andysellick
Use correct component references
887399c 
- these two components have been renamed to match conventions, so updating their references here as well
@andysellick
Add missing print stylesheet
66051eb
@bevanloon bevanloon temporarily deployed to government-f-fix-compon-gusjb3 January 14, 2021 16:36 Inactive
maxgds
maxgds approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@maxgds maxgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine, just think the skip-link addition might want to be mentioned in the PR as it doesn't look like rename.

app/assets/stylesheets/print.scss Show resolved Hide resolved
@andysellick andysellick merged commit 617382c into master Jan 18, 2021
@andysellick andysellick deleted the fix-component-references branch January 18, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgds maxgds maxgds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysellick @maxgds @bevanloon