Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer render text as <strong> importance #1973

Merged
merged 1 commit into from
Jan 11, 2021
Merged

No longer render text as <strong> importance #1973

merged 1 commit into from
Jan 11, 2021

Conversation

Rosa-Fox
Copy link
Contributor

The last line should not be <strong>, so this has been amended.

Before

government-frontend-before

After

gov-frontend-after

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@Rosa-Fox
No longer render text as <strong> importance
a3808b4 
The last line should not be <strong>, so this has been amended.
@bevanloon bevanloon temporarily deployed to government-f-remove-str-qqexyh January 11, 2021 16:09 Inactive
GDSNewt
GDSNewt approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@GDSNewt GDSNewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

kevindew
kevindew approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

It does seem a bit surprising not having the whole paragraph bold but I'm assuming you've already dug into whether it's really wanted this way.

@Rosa-Fox Rosa-Fox merged commit 5adafb4 into master Jan 11, 2021
@Rosa-Fox Rosa-Fox deleted the remove-strong-importance-from-sentence branch January 11, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GDSNewt GDSNewt GDSNewt approved these changes

@kevindew kevindew kevindew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rosa-Fox @kevindew @GDSNewt @bevanloon