Set i18n.direction to rtl for languages DR, PA-UR, PS #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corresponding ticket: https://govuk.zendesk.com/agent/tickets/4398151. These languages are right-to-left (RTL) in Whitehall, but not in this frontend app: https://github.com/alphagov/whitehall/blob/bcda05ec43d87b3bec1541e644c1373bafa2a3e8/config/locales/ps.yml#L315-L316 This will ensure pages such as this one are rendered correctly: https://www.gov.uk/guidance/coronavirus-covid-19-taxis-and-phvs.ps How the page should look (with different language with correct cofig): https://www.gov.uk/guidance/coronavirus-covid-19-taxis-and-phvs.ar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding ticket: https://govuk.zendesk.com/agent/tickets/4398151.
These languages are right-to-left (RTL) in Whitehall, but not in this frontend app:
https://github.com/alphagov/whitehall/blob/bcda05ec43d87b3bec1541e644c1373bafa2a3e8/config/locales/ps.yml#L315-L316
This will ensure pages such as this one are rendered correctly:
https://www.gov.uk/guidance/coronavirus-covid-19-taxis-and-phvs.ps
How the page should look (with different language with correct cofig):
https://www.gov.uk/guidance/coronavirus-covid-19-taxis-and-phvs.ar