Fix corporate information pages error #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihugh
force-pushed
the
fix-corp-info-groups-error
branch
from
b31ddd7 to
a6fa3f0
Compare
Some [corporate information pages](https://www.gov.uk/government/organisations/migration-advisory-committee/about) are erroring because the list of IDs in corporate information groups in the details hash doesn't match the list of linked corporate information pages in the links hash. Even if they do eventually resolve, these two lists will occasionally be out of sync when they're updated because of the way our publishing system works. We should defend against this so it doesn't error. Resolves this [sentry error](https://sentry.io/organizations/govuk/issues/1813208304/?environment=production&project=202226&query=is%3Aunresolved&statsPeriod=14d)
sihugh
force-pushed
the
fix-corp-info-groups-error
branch
from
a6fa3f0 to
0be0eac
Compare
brucebolt
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some corporate information pages are erroring because the list of IDs in corporate information groups in the details hash doesn't match the list of linked corporate information pages in the links hash.
Even if they do eventually resolve, these two lists will occasionally be out of sync when they're updated because of the way our publishing system works. We should defend against this so it doesn't error.
Resolves this sentry error
Compare:
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.