Remove hidden "Share on" from share links text #1916
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
shareon-shareon
branch
from
92084ed to
8f0a151
Compare
The share links now have "Share on" as visually hidden text by default. This helps AT users make sense of the links (ie "Share on Facebook" makes more sense than just "Facebook"). Therefore it is not necessary to add this visually hidden text on the rendering app side.
danacotoran
force-pushed
the
shareon-shareon
branch
from
8f0a151 to
c129f15
Compare
chris-gds
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The share links component has "Share on" as visually hidden text by default.
This helps AT users make sense of the links (ie "Share on Facebook" makes more sense than just "Facebook").
It looks like
government-frontendis also adding a hidden "Share on" as part of the share links text. This is causing an issue where hidden content is being repeated e.g. "Share on Share on Facebook".https://trello.com/c/shAQ6AQu/460-social-media-links-repeat-hidden-content-bug
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.