Use heading level 3 for attachments #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
attachment-heading-level
branch
from
df7f680 to
f04e863
Compare
chris-gds
reviewed
Nov 18, 2020
| <%= render 'govuk_publishing_components/components/attachment', | ||
| attachment: @content_item.attachment_details(attachment_id) %> | ||
| <%= render 'govuk_publishing_components/components/attachment', { | ||
| heading_level: 3, |
There was a problem hiding this comment.
Looks fines since you've added to gem, will take a look once on integration.
danacotoran
force-pushed
the
attachment-heading-level
branch
from
f04e863 to
737d3f6
Compare
danacotoran
force-pushed
the
attachment-heading-level
branch
from
8e1f82b to
102854c
Compare
chris-gds
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attachments are currently hard coded to use
h2which isn't very flexible. The attachment component is often used as a child of a section of a page, in which case the heading level of the component should be adjusted to reflect the hierarchy of the content.There is already a
h2inapp/views/content_items/_attachments.html.erb– it does not make sense that the attachments have the same heading level as their parent. This specifies that they useh3instead.Related PRs:
https://trello.com/c/KzyicaBh/491-publications-confusing-heading-structure
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.