Swap sanitize for raw when used in Govspeak component #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sanitize` method was stripping out tables for reasons. This replaces it with the slightly more risky `raw` method that doesn't break the markup. Using `sanitize`s allow list meant listing most of the HTML elements, and introducing a risk of further breakages if a element is accidently left out of the allow list.
injms
changed the title
injms
changed the title
injms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replaces
sanitisewithrawin detailed guide template.Why
The
sanitizemethod was stripping out tables for reasons. But usingsanitizes allow list meant listing most of the HTML elements, and introducing a risk of further breakages if a element is accidently left out of the allow list - so usingrawwas the least worst compromise between fixing this now, fixing this in the future, and security.Visual differences
Before:
After:
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.