Add healthcheck for memcached #1880
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this repo had a very basic healthcheck. This extends it with a more thorough check of the infrastructure it needs to run: Memcached [1] [2]. Since the caching can fail silently, there is even more motivation for us to know about it. [1]: https://github.com/alphagov/slimmer/blob/64482b28572a7d038827de214832317e75f0c1ae/lib/slimmer.rb#L13 [2]: https://github.com/alphagov/government-frontend/blob/0bd1bbad134b2ddb521e2372b45df0d08bc7b142/Gemfile#L5
|
Tested on Integration and works 👍. |
thomasleese
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/epNWudCR/176-write-an-rfc-for-continuous-deployment-and-seek-review
Previously this repo had a very basic healthcheck. This extends it
with a more thorough check of the infrastructure it needs to run:
Memcached 1 2. Since the caching can fail silently, there is
even more motivation for us to know about it.
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.