Replace bespoke nav with contents list component #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Non-blocking comment that I noticed post approval: The contents section is now quite snug to the left side on mobile. |
Thanks, I realised it was too far over at all widths, actually. Have amended, could you re-check, please? |
kevindew
added a commit
that referenced
this pull request
Aug 6, 2021
There is a bug where these navigation links are sending two GA events per click. This is occurring because the contents-list component has an undocumented [1] feature of tracking links which was presumably not known about when this code was changed to use this component [2]. The resolution for this is to remove the usage of track links on the nav element and just use the components one. [1]: https://github.com/alphagov/govuk_publishing_components/blob/147a825fc7608eb3dfdaab0d418c5b2fdaaf08aa/app/views/govuk_publishing_components/components/docs/contents_list.yml [2]: #1877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the bespoke 2 column layout for parts navigation and replaces it with the contents-list component. This brings in a header of "Contents" and makes the navigation more consistent with the rest of the site which is good for accessibility.
https://trello.com/c/LbVmpaK6/441-inconsistent-naming-of-table-of-contents
Sample page: https://www.gov.uk/foreign-travel-advice/switzerland
Before
After