Remove internal notes from specialist document presenter #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain Specilialist Documents can have internal notes that should not be presented on the frontend.
thomasleese
approved these changes
Sep 25, 2020
AlanGabbianelli
pushed a commit
that referenced
this pull request
Oct 15, 2020
This is a departmental request that came through [Zendesk](https://govuk.zendesk.com/agent/tickets/4197468) and will conditionally display logos for specialist documents of the newly added type `protected_food_drink_name`. Context on why and how `protected_food_drink_name` was added can be found these PRs: - alphagov/specialist-publisher#1720 - alphagov/govuk-content-schemas#1013 - alphagov/search-api#2186 - #1867 The logos added are placeholders while we wait for higher resolution and properly cropped ones. The test added in `test/presenters/specialist_document_presenter_test.rb:21` depends on the the schema example added in alphagov/govuk-content-schemas#1020 Trello card: https://trello.com/c/NKJYyZep/2157-3-update-protected-food-names-frontend-template
AlanGabbianelli
pushed a commit
that referenced
this pull request
Oct 16, 2020
This is a departmental request that came through [Zendesk](https://govuk.zendesk.com/agent/tickets/4197468) and will conditionally display logos for specialist documents of the newly added type `protected_food_drink_name`. Context on why and how `protected_food_drink_name` was added can be found these PRs: - alphagov/specialist-publisher#1720 - alphagov/govuk-content-schemas#1013 - alphagov/search-api#2186 - #1867 The logos added are placeholders while we wait for higher resolution and properly cropped ones. The test added in `test/presenters/specialist_document_presenter_test.rb:21` depends on the the schema example added in alphagov/govuk-content-schemas#1020 Trello card: https://trello.com/c/NKJYyZep/2157-3-update-protected-food-names-frontend-template
AlanGabbianelli
pushed a commit
that referenced
this pull request
Oct 16, 2020
This is a departmental request that came through [Zendesk](https://govuk.zendesk.com/agent/tickets/4197468) and will conditionally display logos for specialist documents of the newly added type `protected_food_drink_name`. Context on why and how `protected_food_drink_name` was added can be found in these PRs: - alphagov/specialist-publisher#1720 - alphagov/govuk-content-schemas#1013 - alphagov/search-api#2186 - #1867 The logos added are placeholders while we wait for higher resolution and properly cropped ones. The test added in `test/presenters/specialist_document_presenter_test.rb:21` depends on the the schema example added in alphagov/govuk-content-schemas#1020 Trello card: https://trello.com/c/NKJYyZep/2157-3-update-protected-food-names-frontend-template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain Specialist Documents can have internal notes that
should not be presented on the frontend.
Trello