Restore asset compress after Rails 6 upgrade #1843
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
previously approved these changes
Aug 25, 2020
pixeltrix
reviewed
Aug 25, 2020
Because the default for Rails 6 is to use webpack for JS the Sprockets js_compressor option is not set in the generated production.rb environment file. This leads to bloated file sizes in production so re-enable compression by explicitly setting it
EGiataganas
force-pushed
the
fix-asset-compression
branch
from
8790799 to
2e1ca34
Compare
pixeltrix
approved these changes
Aug 25, 2020
MuriloDalRi
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes to
production.rbto restore asset compression to previous output.Why
Visual differences
None.