Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus states for 'applies to' links #1832

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

andysellick
Copy link
Contributor

⚠️ This application is Continuously Deployed: ⚠️

  • Merged changes are automatically deployed to staging and production.

  • Make sure you follow the guidance for deployments before you merge.

  • Check your branch is being deployed in the Release app, after merging.

What/why

Fixes the focus state for links in the important metadata component, on pages like https://www.gov.uk/guidance/coronavirus-covid-19-travel-corridors

Before:

Screenshot 2020-08-14 at 14 11 47

After:

Screenshot 2020-08-14 at 14 11 58

This occurred on visited links when focussed.

- when the link has been visited and then focussed, the style was for white text on a yellow (focussed) background
- adds an explicit focus state colour to fix this
@bevanloon bevanloon temporarily deployed to government-f-fix-applie-qvtm47 August 14, 2020 13:18 Inactive
@andysellick andysellick merged commit 9756af9 into master Aug 14, 2020
@andysellick andysellick deleted the fix-applies-to-link-styles branch August 14, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants