Use print link component from govuk_publishing_components #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got any example URLs where the print link can be seen? |
This replaces the app component with the new component provided by the govuk_publishing_component. They should be functionally and visually equivalent.
This has been replaced by the component in the govuk_publishing_components. This code is no longer used.
theseanything
force-pushed
the
replace-print-link-component
branch
from
2da6b45 to
e33453f
Compare
@andysellick Added to the description :) Those are the only two content types that show print links. |
andysellick
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the application component with the new component provided by govuk_publishing_components. Unused code for the application component is removed.
The components should be functional and visually equivalent.
Visual regression results:
before:
https://government-frontend.herokuapp.com/foreign-travel-advice/australia
https://government-frontend.herokuapp.com/universal-credit
after:
https://government-f-replace-pr-1cuoiy.herokuapp.com/foreign-travel-advice/australia
https://government-f-replace-pr-1cuoiy.herokuapp.com/universal-credit