Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin top to organisation logos #1789

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

andysellick
Copy link
Contributor

  • this prevents the contextual breadcrumb component, when showing the step nav header component, from colliding with it
  • the step nav component has no margin bottom, but the other components that can be displayed in the contextual breadcrumb do, so this change should not impact variations on this layout as the newly added top margin will overlap any bottom margin from the breadcrumb

Happens on pages like: https://www.gov.uk/government/publications/coronavirus-covid-19-guidance-on-phased-return-of-sport-and-recreation/elite-sport-return-to-domestic-competition-guidance

Before:

Screenshot 2020-06-02 at 15 53 40

After:

Screenshot 2020-06-02 at 15 53 47

- this prevents the contextual breadcrumb component, when showing the step nav header component, from colliding with it
- the step nav component has no margin bottom, but the other components that can be displayed in the contextual breadcrumb do, so this change should not impact variations on this layout as the newly added top margin will overlap any bottom margin from the breadcrumb
@andysellick andysellick requested a review from sihugh June 2, 2020 14:57
@bevanloon bevanloon temporarily deployed to government-f-fix-step-n-x43azk June 2, 2020 14:57 Inactive
Copy link
Contributor

@reggieb reggieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andysellick andysellick merged commit 0ad24e4 into master Jun 3, 2020
@andysellick andysellick deleted the fix-step-nav-header-org-logo branch June 3, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants