Move history index page #1788
Merged
Move history index page #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The notable changes between the template rendered in whitehall and this are as follows: * width set to 100% for image tags to stop divs overlapping when shrinking the screen * extra div to give some bottom padding to the content -> 'govuk-body govuk-!-padding-bottom-6' * use hardcoded links instead of rails path helpers * figcaption now displays slightly differently but is more inline with figcaptions in the repo * removed unused methods and styles
Update controller to allow rendering the history index page.
1pretz1
force-pushed
the
add-history-index-page
branch
from
2457980 to
307b525
Compare
This also adds a call to publishing-api which overrides the publishing app's path reservation for the base_path. The reservation is overwritten and updated so the publishing app is government-frontend.
1pretz1
force-pushed
the
add-history-index-page
branch
from
307b525 to
58ce848
Compare
thomasleese
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to move the static history index page from whitehall to government-frontend.
Local page
Live page (https://www.gov.uk/government/history)
Trello:
https://trello.com/c/mGQh44wr/1983-3-render-static-pages-in-government-frontend
Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html