Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant RuboCop config #1782

Merged
merged 1 commit into from
May 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,3 @@ inherit_gem:
inherit_mode:
merge:
- Exclude

Metrics/BlockLength:
Exclude:
- "test/**/*_test.rb"

Rails/OutputSafety:
Enabled: false
Rails/HelperInstanceVariable:
Enabled: false
2 changes: 1 addition & 1 deletion app/helpers/machine_readable_metadata_helper.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module MachineReadableMetadataHelper
def machine_readable_metadata(args)
locals = { content_item: @content_item.content_item }.merge(args)
locals = { content_item: @content_item.content_item }.merge(args) # rubocop:disable Rails/HelperInstanceVariable
render("govuk_publishing_components/components/machine_readable_metadata", locals)
end
end
2 changes: 1 addition & 1 deletion app/helpers/webchat_availability_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module WebchatAvailabilityHelper

def webchat_unavailable?(now = Time.zone.now)
show_unavailability = now >= UNAVAILABILITY_START && now < UNAVAILABILITY_END
show_unavailability && HMRC_WEBCHAT_CONTACT_PATHS.include?(@content_item.base_path)
show_unavailability && HMRC_WEBCHAT_CONTACT_PATHS.include?(@content_item.base_path) # rubocop:disable Rails/HelperInstanceVariable
end

def unavailability_message
Expand Down