Switch asset hostname #1767
Merged
Switch asset hostname #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
approved these changes
May 21, 2020
This is in preparation for these assets to be on www.gov.uk
This removes this global environment variable on the expectation that assets will be served from www.gov.uk and thus won't need configuring. A new environment variable ASSET_HOST is created so that a host can still be specified. This is useful for when you are serving government-frontend behind router but haven't set up asset proxying. This is the case in the govuk-docker development environment for example. This also removes unnecessary slimmer configuration as that is the default option.
This isn't necessary if assets aren't served on a particular host.
This shouldn't be needed if assets are served at a relative path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/oNEtjIVp/99-serve-static-assets-from-www-hostname
This is marked as a draft until the following PR's are merged (and in puppets case, deployed):
This removes the configuration in this app that specifies that this app should use the
assets.publishing.service.gov.ukhostname for serving assets with the expectation that these assets will instead be served off thewwwhostname. This is to implement RFC 115. Because of this the path to assets will be changed to be prefixed with/assetsso all GOV.UK assets are hosted in the same path.The asset host can still be configured in this app by a
ASSET_HOSTenvironment variable, this will be used in govuk-docker and publishing-e2e-tests to avoid needing additional nginx configuration.