Add GA params to /ask survey link #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
793dbe5 to
2d012e5
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
2d012e5 to
f5e41d7
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
f5e41d7 to
88355e9
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
88355e9 to
8f84285
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
410e166 to
8f84285
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
8f84285 to
958f097
Compare
This clearly can be de-duplicated between SetGaClientIdOnForm, which will come in future commit.
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
958f097 to
b0daccb
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
69ab950 to
d8c15f9
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
d8c15f9 to
1b31ea1
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
1b31ea1 to
37d322e
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
37d322e to
6aed666
Compare
chao-xian
force-pushed
the
add-ga-param-for-ask
branch
from
6aed666 to
316dad6
Compare
vanitabarrett
approved these changes
Apr 24, 2020
kevindew
added a commit
to alphagov/frontend
that referenced
this pull request
May 8, 2020
The gov.uk/ask service cannot use the existing cross-domain tracking abilities set-up in publisher as we do not have google analytics running on the destination Smart Survey, instead we need to pass this via a query string variable. To achieve this we look for any links to our particular Smart Survey when the page loads for users who have allowed Google Analytics and then add a query string of the client Id from Analytics. This change ports over the work from alphagov/government-frontend#1744 which was done to enable this to run on an Answer page format, moving it here allows this to be done on a transaction format instead. I've put in the famous last words in a comment of "this should only be short term" hopefully this doesn't come back to haunt me.
kevindew
added a commit
to alphagov/frontend
that referenced
this pull request
May 11, 2020
The gov.uk/ask service cannot use the existing cross-domain tracking abilities set-up in publisher as we do not have google analytics running on the destination Smart Survey, instead we need to pass this via a query string variable. To achieve this we look for any links to our particular Smart Survey when the page loads for users who have allowed Google Analytics and then add a query string of the client Id from Analytics. This change ports over the work from alphagov/government-frontend#1744 which was done to enable this to run on an Answer page format, moving it here allows this to be done on a transaction format instead. I've put in the famous last words in a comment of "this should only be short term" hopefully this doesn't come back to haunt me.
This was referenced May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to compare the number of people who go on to see the survey vs the people who complete so that we can work out the rate.
Trello https://trello.com/c/La96nEZw
Visual regression results:
https://government-frontend-pr-1744.surge.sh/gallery.html