Use individual component sass #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
andysellick
force-pushed
the
use-individual-component-sass
branch
from
4e0db4b to
059077b
Compare
andysellick
requested review from
injms,
maxgds,
vanitabarrett,
alex-ju and
chao-xian
andysellick
changed the title
andysellick
force-pushed
the
use-individual-component-sass
branch
5 times, most recently
from
2e85128 to
0e1bb50
Compare
- this was previously built using styles from the warning component but not the component itself - component could not be used because this part of the page required a heading - component has since been upgraded to include an option to display as a heading, so can now be used
andysellick
force-pushed
the
use-individual-component-sass
branch
from
0e1bb50 to
d8c0f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update government-frontend to import the sass for only the components it is using, instead of all components, as documented here.
Filesize comparison
Before:
Total 851 KB
After:
Total 628 KB
Additional changes
Also update all travel pages (such as foreign travel advice to the USA) to use the warning text component. This was previously not possible because the component did not allow for a heading but has been updated to allow this.
This is being done as part of this PR because this page used styles from the component but not the component itself - so I noticed it had broken when I made the Sass change (because the warning text component is not used anywhere, it was not part of the 'suggested sass' output. It now is).
Trello card: https://trello.com/c/GWttlBxs/228-upgrade-applications-to-use-individual-component-sass