Header notice spacing tweaks #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
header-notice-tweaks
branch
from
a99d1e2 to
e2480f4
Compare
alex-ju
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
I have one subjective, non-blocking comment otherwise really happy to see this visual fix. If the header is required I would be tempted to remove the top border from app-c-header-notice__content instead of adding a padding exception to the app-c-header-notice__header.
|
@alex-ju That makes sense! This change isn't urgent so will amend as part of this PR 🙂 |
vanitabarrett
force-pushed
the
header-notice-tweaks
branch
from
e2480f4 to
361986f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Before
After