rubocop: Set inherit_mode: merge for Excludes
#1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We found that for apps that used Ruby-only cops, the recent changes in gem version 3.1.0 to exclude `bin/` files from linting worked fine. - For apps that used Rails cops as well, the changes didn't work for `bin/` but they did work for `db/schema.rb` which is excluded from linting in `config/rails.yml`. - This is because RuboCop by default *overwrites* any previous definitions of a config option when it detects a later one: https://rubocop.readthedocs.io/en/latest/configuration/#merging-arrays-using-inherit_mode. - Unfortunately, we'll have to specify this `inherit_mode` stanza in every app. https://trello.com/c/i72oq9Xa/1810-fix-rubocop-config-file-inheritance-in-all-the-apps
thomasleese
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gem version 3.1.0 to exclude
bin/files from linting worked fine.bin/but they did work fordb/schema.rbwhich is excluded fromlinting in
config/rails.yml.definitions of a config option when it detects a later one:
https://rubocop.readthedocs.io/en/latest/configuration/#merging-arrays-using-inherit_mode.
inherit_modestanza inevery app.
https://trello.com/c/i72oq9Xa/1810-fix-rubocop-config-file-inheritance-in-all-the-apps
Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html