Support redirecting to asset preview URLs #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the route for assets assumes that it ends with a file extension (for example `.pdf`). In the case of the preview URLs (which end with `/preview`) it thinks the format of the page is `.pdf/preview`. This gets URL encoded into `.pdf%2Fpreview` by Rails and so the redirect doesn't work. Rather than handling the file extension special, this PR changes it to accept any path containing any number of file extensions or slashes in no particular format.
cbaines
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the route for assets assumes that it ends with a file extension (for example
.pdf). In the case of the preview URLs (which end with/preview) it thinks the format of the page is.pdf/preview. This gets URL encoded into.pdf%2Fpreviewby Rails and so the redirect doesn't work.Rather than handling the file extension special, this PR changes it to accept any path containing any number of file extensions or slashes in no particular format.