Handle old-style /goverment/uploads routes #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently handled by Whitehall but we're trying to move away from Whitehall being a frontend application. The next best place for this bit of code seems to be Government Frontend. https://github.com/alphagov/whitehall/blob/master/test/functional/asset_manager_redirect_controller_test.rb The code itself is used to handle assets which are still being requested on their own URL before we migrated all assets over to Asset Manager.
cbaines
approved these changes
Mar 9, 2020
thomasleese
added a commit
to alphagov/whitehall
that referenced
this pull request
Mar 9, 2020
This is now handled by government-frontend to reduce the number of requests going to Whitehall. alphagov/government-frontend#1677
thomasleese
added a commit
to alphagov/whitehall
that referenced
this pull request
Mar 9, 2020
This is now handled by government-frontend to reduce the number of requests going to Whitehall. alphagov/government-frontend#1677
thomasleese
added a commit
to alphagov/whitehall
that referenced
this pull request
Mar 9, 2020
This is now handled by government-frontend to reduce the number of requests going to Whitehall. alphagov/government-frontend#1677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently handled by Whitehall but we're trying to move away from Whitehall being a frontend application. The next best place for this bit of code seems to be Government Frontend.
The code itself is used to handle assets which are still being requested on their own URL before we migrated all assets over to Asset Manager.
Once this is merged and deployed, I will set up a route in Special Route Publisher which sends requests prefixed with
/government/uploadsto Government Frontend.Trello Card