Use a placeholder image from asset-manager #1669
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past this linked to an image served by Whitehall, but because of the way Rails generates hashes for assets, we can't guarantee that this URL will always exist. This hasn't been a problem in the past because we've been able to put an unhashed version of the image on the Whitehall machines, but since moving to AWS the machines can be recreated at any moment and won't have the file. To solve this problem I've uploaded the file to Asset Manager and we can link to that instead. Ideally, we wouldn't depend on a file in a different application, but this solves the problem for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past this linked to an image served by Whitehall, but because of the way Rails generates hashes for assets, we can't guarantee that this URL will always exist. This hasn't been a problem in the past because we've been able to put an unhashed version of the image on the Whitehall machines, but since moving to AWS the machines can be recreated at any moment and won't have the file.
To solve this problem I've uploaded the file to Asset Manager and we can link to that instead. Ideally, we wouldn't depend on a file in a different application, but this solves the problem for now.
This is similar to alphagov/collections#1522.
Trello Card