Override old "documents" fields with new "attachments" fields #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilbof
approved these changes
Feb 17, 2020
| def initialize(old_list, new_list) | ||
| @content_item = { | ||
| "base_path" => "/a/base/path", | ||
| "details" => { "old_badness" => old_list, "new_hotness" => new_list }.compact, |
barrucadu
force-pushed
the
msw/rfc-116
branch
from
2225ff2 to
479af95
Compare
If both are set and the attachments field is the same size as the documents field. If they're not the same size an error is logged. We can use this to be confident that, after republishing everything, we've not somehow lost any data. When we're happy to remove the old field, we can revert this commit and just use the new field directly.
barrucadu
force-pushed
the
msw/rfc-116
branch
from
479af95 to
4139f42
Compare
|
Got an error on the heroku preview app when I tried to preview a random consultation, just checking that out now |
|
Looks unrelated, and the master branch preview for consultations is broken too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both are set and the attachments field is the same size as the
documents field. If they're not the same size an error is logged. We
can use this to be confident that, after republishing everything,
we've not somehow lost any data.
When we're happy to remove the old field, we can revert this commit
and just use the new field directly.
Trello card
Visual regression results:
https://government-f-msw-rfc-11-dk2x9g.surge.sh/gallery.html