Hmrc webchat update to JSON availability reqest #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilwoarH
reviewed
Jan 30, 2020
DilwoarH
reviewed
Jan 30, 2020
DilwoarH
reviewed
Jan 30, 2020
| @@ -40,7 +40,7 @@ | |||
| <% if @content_item.try(:back_link) %> | |||
| <%= render 'govuk_publishing_components/components/back_link', href: @content_item.back_link %> | |||
| <% else %> | |||
| <%= render 'govuk_publishing_components/components/contextual_breadcrumbs', content_item: @content_item.content_item.parsed_content %> | |||
| <%= render 'govuk_publishing_components/components/contextual_breadcrumbs', content_item: @content_item.content_item.parsed_content%> | |||
There was a problem hiding this comment.
could we remove this change from the commit history
|
Looks okay but we need to squash the commit history |
RobBond-GDS
force-pushed
the
HMRC-webchat-JSONP-investigation
branch
from
25d7792 to
68a6da3
Compare
RobBond-GDS
force-pushed
the
HMRC-webchat-JSONP-investigation
branch
from
68a6da3 to
16d0c73
Compare
RobBond-GDS
force-pushed
the
HMRC-webchat-JSONP-investigation
branch
from
16d0c73 to
78e6fd8
Compare
|
If you squash the commits, we can get this merged in |
did we not squash commits yesterday? |
There were new changes were introduced in the first commit then removed from in the second. So no need to have two commits. One is enough |
|
I believe i committed it subsequently
…On Tue, 4 Feb 2020 at 10:07, Dilwoar Hussain ***@***.***> wrote:
in
did we not squash commits yesterday?
There were new changes were introduced in the first commit then removed
from in the second. So no need to have two commits. One is enough
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1642?email_source=notifications&email_token=ANAYF7ACQCXH5YYY6VDTI6TRBE46NA5CNFSM4KNVQ6G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKXBKZQ#issuecomment-581834086>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANAYF7BZKWEAXHWB5CG34LTRBE46NANCNFSM4KNVQ6GQ>
.
|
…d payload attribute to default to json remove payload as request defeaults to json remove payload as request defeaults to json
RobBond-GDS
force-pushed
the
HMRC-webchat-JSONP-investigation
branch
from
a2862a6 to
da21d68
Compare
DilwoarH
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the default availability request to be in JSON as opposed to JSONP.
Need to check on integration as this environment has been "whitelisted" to allow requests to the Nuance server.
Note: Local Dev environments using port numbers have not been included
Visual regression results:
https://government-frontend-pr-1642.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1642.herokuapp.com/component-guide