Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show no deal notice with no links #1638

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Show no deal notice with no links #1638

merged 3 commits into from
Jan 29, 2020

Conversation

laurentqro
Copy link
Contributor

@laurentqro laurentqro commented Jan 28, 2020 •
edited by vanitabarrett
Loading

Trello: https://trello.com/c/fBavxD33/426-no-deal-notice-should-display-if-no-links-provided

When the publisher in Whitehall ticks the checkbox for the notice to be displayed with no links, the brexit_no_deal_notice is present, with a value of [].

We were expecting to see the notice in this case. However, the code was assuming we should only show the notice if links were present.

@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 11:26 Inactive
@laurentqro laurentqro requested review from huwd and koetsier January 28, 2020 11:26
@vanitabarrett
Copy link
Contributor

@laurentqro I don't think the header-notice component checks for links or not. This might mean the link_intro is displayed even when there are no links, which wouldn't make sense. Can we add an example with link_intro and without links to this file, so we can test the component?

@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 11:58 Inactive
@vanitabarrett vanitabarrett force-pushed the no-deal-notice-no-links branch from 31189c3 to 98fed4b Compare January 28, 2020 12:00
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 12:00 Inactive
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 13:26 Inactive
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 13:32 Inactive
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 13:38 Inactive
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 13:43 Inactive
@vanitabarrett vanitabarrett force-pushed the no-deal-notice-no-links branch from 8de92ba to 9770581 Compare January 28, 2020 13:48
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 13:49 Inactive
@vanitabarrett vanitabarrett force-pushed the no-deal-notice-no-links branch from 9770581 to 97ee34a Compare January 28, 2020 14:03
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 14:03 Inactive
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 14:19 Inactive
@vanitabarrett vanitabarrett force-pushed the no-deal-notice-no-links branch from da0ac89 to 3e9b4eb Compare January 28, 2020 14:39
@bevanloon bevanloon temporarily deployed to government-f-no-deal-no-joqafd January 28, 2020 14:39 Inactive
@vanitabarrett vanitabarrett merged commit 512c9f8 into master Jan 29, 2020
@vanitabarrett vanitabarrett deleted the no-deal-notice-no-links branch January 29, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwd huwd huwd approved these changes

@vanitabarrett vanitabarrett Awaiting requested review from vanitabarrett

@koetsier koetsier Awaiting requested review from koetsier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurentqro @vanitabarrett @huwd @bevanloon