Roll out Dataset schema to more types #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: > #content_store_has_item is deprecated on GdsApi::TestHelpers::ContentStore > and will be removed in a future version. Use #stub_content_store_has_item instead
Resolves: > #content_store_does_not_have_item is deprecated on GdsApi::TestHelpers::ContentStore > and will be removed in a future version. Use #stub_content_store_does_not_have_item > instead
Resolves: > #content_store_has_gone_item is deprecated on GdsApi::TestHelpers::ContentStore > and will be removed in a future version. Use #stub_content_store_has_gone_item > instead
I think this was probably a typo from someone who had been writing a lot of javascript. It's almost certainly not the intention.
The national_statistics, official_statistics and transparency document types also contain datasets so will benefit from better structured data.
sihugh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use the correct schema.org type as much as possible. National statistics, Official statistics and Transparency types contain things of interest to people searching for open data.
I've fixed a bunch of gds-api-adapter deprecation warnings as part of this PR, so reviewing by commit might be advised.
I also discovered a
===comparison which I'm not sure is intended, so I've flipped it back to==.Example pages: