Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hmrc provdier yaml #1622

Merged
merged 15 commits into from
Jan 21, 2020
Merged

New hmrc provdier yaml #1622

merged 15 commits into from
Jan 21, 2020

Conversation

RobBond-GDS
Copy link
Contributor

@RobBond-GDS RobBond-GDS commented Jan 16, 2020

updated the webchat yaml to point to the new nuance urls - pul lrequest to facilitate testing


Visual regression results:
https://government-frontend-pr-1622.surge.sh/gallery.html

Component guide for this PR:
https://government-frontend-pr-1622.herokuapp.com/component-guide

@RobBond-GDS RobBond-GDS requested a review from DilwoarH January 16, 2020 10:34
@karlbaker02 karlbaker02 temporarily deployed to government-frontend-pr-1622 January 16, 2020 10:35 Inactive
@karlbaker02 karlbaker02 temporarily deployed to government-frontend-pr-1622 January 16, 2020 15:58 Inactive
@karlbaker02 karlbaker02 temporarily deployed to government-frontend-pr-1622 January 17, 2020 07:23 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-1622 January 21, 2020 09:15 Inactive
@RobBond-GDS RobBond-GDS requested a review from alex-ju January 21, 2020 12:02
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-1622 January 21, 2020 12:24 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-1622 January 21, 2020 12:39 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-1622 January 21, 2020 13:00 Inactive
Copy link
Contributor

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me. I left two comments. The commented line should be removed and we may want to lint the code a bit, otherwise good to be tested in integration.

app/assets/javascripts/webchat/library.js Outdated Show resolved Hide resolved
app/assets/javascripts/webchat/library.js Outdated Show resolved Hide resolved
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-1622 January 21, 2020 16:54 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-1622 January 21, 2020 17:08 Inactive
@RobBond-GDS RobBond-GDS deleted the new-HMRC-provdier-yaml branch January 21, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants