Update print icons to come from govuk_publishing_components #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
changed the title
vanitabarrett
changed the title
vanitabarrett
changed the title
andysellick
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update govuk_publishing_components to the latest version, version 21.19.0
Why
Before (checker start page)
After (checker start page)
Before (print icons)
Coming from:
https://assets.publishing.service.gov.uk/government-frontend/icon-print-2x....Should be no visual changes
After (print icons)
Coming from:
https://assets.integration.publishing.service.gov.uk/government-frontend/govuk_publishing_components/icon-print-2x....Should be no visual changes
Herokuapp: https://government-frontend-pr-1616.herokuapp.com/student-finance