Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compatibility flag for focus state colours and remove manual fixes #1573

Merged
merged 10 commits into from
Dec 9, 2019

Conversation

maxgds
Copy link
Contributor

@maxgds maxgds commented Dec 5, 2019

https://trello.com/c/nhfpb4wh/139-revisit-government-frontend-in-light-of-knowing-about-the-govuk-compatibility-govuktemplate-flag

This switches to using the $govuk-compatibility-govuktemplate and removes other code that was implemented to get the correct focus states.

The only visual change should be an update to the focus state of buttons when they are both hovered/active and focused.

Button example page: https://www.gov.uk/settled-status-eu-citizens-families/applying-for-settled-status

Before

Screenshot 2019-12-05 at 08 46 25

After

Screenshot 2019-12-05 at 08 45 47


Examples of pages affected by updates, where no visual change is expected:

@bevanloon bevanloon temporarily deployed to government-frontend-pr-1573 December 5, 2019 08:50 Inactive
@maxgds maxgds changed the title Use compatibility flag and remove manual fixes for gems [WIP] Use compatibility flag and remove manual fixes for gems Dec 5, 2019
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1573 December 5, 2019 09:51 Inactive
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1573 December 5, 2019 10:02 Inactive
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1573 December 5, 2019 10:25 Inactive
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1573 December 5, 2019 10:58 Inactive
@maxgds maxgds force-pushed the use-template-flag branch from b14942a to 2d2ef03 Compare December 5, 2019 12:00
@maxgds maxgds changed the title [WIP] Use compatibility flag and remove manual fixes for gems Use compatibility flag and remove manual fixes Dec 5, 2019
@maxgds maxgds changed the title Use compatibility flag and remove manual fixes Use compatibility flag for focus state colours and remove manual fixes Dec 5, 2019
@maxgds maxgds requested a review from injms December 5, 2019 12:15
@maxgds maxgds merged commit 81d1e45 into master Dec 9, 2019
@maxgds maxgds deleted the use-template-flag branch December 9, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants