Switch to using the government from links, rather than the details #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Whitehall includes the details of the associated government for some content in the details. Now Whitehall also links the content to a content item representing the government. Using the linking approach is preferable going forward, as that means the Publishing API can take care of updating the content store when a government changes (becoming historical), rather than Whitehall having to publish new editions. This change to Government Frontend can be deployed once all the relevant content has been linked to the correct government, something which is being done in bulk from Whitehall.
cbaines
force-pushed
the
switch-to-using-the-government-from-the-links
branch
from
0e78042 to
4f06d08
Compare
thomasleese
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Whitehall includes the details of the associated government
for some content in the details. Now Whitehall also links the content
to a content item representing the government.
Using the linking approach is preferable going forward, as that means
the Publishing API can take care of updating the content store when a
government changes (becoming historical), rather than Whitehall having
to publish new editions.
This change to Government Frontend can be deployed once all the
relevant content has been linked to the correct government, something
which is being done in bulk from Whitehall.