Replace govuk-lint with rubocop-govuk and scss_lint-govuk #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issyl0
suggested changes
Nov 26, 2019
Rakefile
Outdated
| t.files = Dir.glob(["app/assets/stylesheets"]) | ||
| end | ||
|
|
||
| task default: [:spec, "jasmine:ci", :rubocop, :scss_lint] |
There was a problem hiding this comment.
This line and line 10 won't work together, I don't think.
Also, rubocop-govuk and scss_lint-govuk are dev/test dependencies, and all these Rakefiles run on Production deploys. You'll have to do something like in alphagov/email-alert-api#1045.
There was a problem hiding this comment.
Ah yeah, I obviously didn't read this closely enough...
I've also added a conditional to avoid the Production environment issue 👍
The GOV.UK Lint gem is deprecated in favour of using Rubocop and scss_lint directly with a set of shared configs.
cbaines
force-pushed
the
replace-govuk-lint
branch
from
28b7668 to
bfec223
Compare
issyl0
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GOV.UK Lint gem is deprecated in favour of using Rubocop and
scss_lint directly with a set of shared configs.