Don't attempt to render pages for Governments #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This content is new to the Publishing API, and while I believe Government Frontend is the appropriate place for it to be rendered, I want to put of that decision, and the decisions around how to render it until after the intended changes to history mode have been made, as that's what I'm focusing on.
thomasleese
approved these changes
Nov 25, 2019
bevanloon
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This content is new to the Publishing API, and while I believe
Government Frontend is the appropriate place for it to be rendered, I
want to put of that decision, and the decisions around how to render
it until after the intended changes to history mode have been made, as
that's what I'm focusing on.