Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query params to schema.org links #1547

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Conversation

sihugh
Copy link
Contributor

@sihugh sihugh commented Nov 20, 2019

We're adding a query param to the links in the FAQSchema to help us measure when traffic is being referred from links parsed from the schema, and when it's coming from more traditional means.

The query param (?foo=bar) should go before the fragment (#baz) where applicable.

We're adding a query param to the links in the FAQSchema to help us measure
when traffic is being referred from links parsed from the schema, and when it's coming from more traditional means.

[The query param (`?foo=bar`) should go before the fragment (`#baz`)](https://tools.ietf.org/html/rfc3986#section-4.2)
where applicable.
Copy link
Contributor

@bilbof bilbof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sihugh sihugh merged commit c8c4982 into master Nov 20, 2019
@sihugh sihugh deleted the voting-in-uk-update-20191119 branch November 20, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants