Update /voting-in-the-uk schema #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content was updated on Friday. There is [a diff of the content changes](https://publisher.publishing.service.gov.uk/editions/5dbc325c40f0b670153e4e18/diff) in Publisher. Only certain sections of the page are included in the schema, because there's a limit to the amount of content that can be included in the FAQ schema. (That's also the reason for using a separate yml config file for this rather than generating it dynamically from the content item). The [initial version of the page](https://docs.google.com/document/d/14g7FK-v_Y5iqWcB9y5WqTUWU6JuY_eaSGAqxXSMb0Ek/edit#heading=h.9w2yx5uysegs) (with the relevant FAQ sections highlighted) is available to review if necessary. This provides a decent indication of which bits are included, but is now out of date. Speak to me or Sam Dub for further details if required.
kr8n3r
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content was updated on Friday so we need to update this to keep it in step. There is a diff of the content changes in Publisher.
The relevant page in the preview app is https://government-frontend-pr-1537.herokuapp.com/voting-in-the-uk
Only certain sections of the page are included in the schema, because there's a limit to the amount of content that can be included in the FAQ schema. (That's also the reason for using a separate yml config file for this rather than generating it dynamically from the content item).
The initial version of the page (with the relevant FAQ sections highlighted) is available to review if necessary). This provides a decent indication of which sections are in scope for the schema, but is now out of date.
There are a couple of existing tests to ensure that this works OK.
Speak to me or Sam Dub for further details if required.