Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off diff linting #1498

Merged
merged 9 commits into from
Sep 24, 2019
Merged

Turn off diff linting #1498

merged 9 commits into from
Sep 24, 2019

Conversation

benthorner
Copy link
Contributor


Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html

Component guide for this PR:
https://government-frontend-pr-[THIS PR NUMBER].herokuapp.com/component-guide

@bevanloon bevanloon temporarily deployed to government-frontend-pr-1498 September 24, 2019 09:40 Inactive
@bevanloon bevanloon temporarily deployed to government-frontend-pr-1498 September 24, 2019 12:54 Inactive
@@ -0,0 +1,3 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - thanks for spotting. It must have been in there before I started.

Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'm assuming you'll plan to delete the package-lock.json file before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants