Use the updated FAQ schema #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihugh
force-pushed
the
answer-schema
branch
from
b0d01f8 to
821b4d8
Compare
The FAQ schema now supports single page bodies rather than multipart guide sections. Some tests in this repo exercise a path where a guide has no parts which is why the conditional in the guide.html.erb view is required. The change to the schema allows us to add it to mainstream answers too.
sihugh
force-pushed
the
answer-schema
branch
from
821b4d8 to
db2f596
Compare
This is repeated a few times now and doesn't add much by being there.
bilbof
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FAQ schema now only supports single page bodies rather than being able to traverse an array of guide sections. This means we should now use the
:faqschema on all guide parts.Some guide tests in this repo exercise a path where a guide has no parts which is why the conditional in the guide.html.erb view is required.
The change to the schema allows us to add it to mainstream answers.
Checkout:
Guides:
Answers:
You can paste the page source into https://search.google.com/structured-data/testing-tool/u/0/ or https://search.google.com/test/rich-results to verify it works. Using the URL fails because we've put auth on the review app.
(I'd preview it for you with a screenshot, but the rich results preview tool seems to be broken)
Component guide for this PR:
https://government-frontend-pr-1492.herokuapp.com/component-guide